Fix UK shortcode, remove deprecated lang prop#4
Open
stepps00 wants to merge 1 commit into
Open
Conversation
nvkelso
requested changes
Jun 6, 2019
Contributor
nvkelso
left a comment
nvkelso
left a comment
There was a problem hiding this comment.
The shortcode must match up with the country codes for the venues and other split by country repos, like https://github.com/whosonfirst-data/whosonfirst-data-venue-gb.
We generally follow ISO for this, which has GB not UK.
Can we store UK and U.K. in the abbreviations section instead?
Contributor
|
/cc @thisisaaronland |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes whosonfirst-data/whosonfirst-data#1618
wof:shortcodevalue toUKwof:langpropertyDoes not require PIP work to update hierarchy. Can merge once approved.